User Tools

Site Tools


principles:single_level_of_abstraction

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
principles:single_level_of_abstraction [2018-04-20 01:39]
40.130.190.160 [Example1: Loops]
principles:single_level_of_abstraction [2019-08-07 00:20] (current)
52.88.14.253 [Description]
Line 23: Line 23:
 A further indicator for a missing method is the combination of a blank line, a comment and a block of code. In most of the cases the code block should go to a new private method. This also makes the comment obsolete as the new method carries a name which typically resembles the comment. ​ A further indicator for a missing method is the combination of a blank line, a comment and a block of code. In most of the cases the code block should go to a new private method. This also makes the comment obsolete as the new method carries a name which typically resembles the comment. ​
  
-Sometimes extracting the method would result in the new method having a large number of parameters. Alternatively the parameters could be converted to fields of the class. But this would often result in bad [[glossary:​cohesion]]. Because of that in such a case extracting a new class is the next step in adhering to the principle.+Sometimes extracting the method would result in the new method having a large number of parameters. Alternatively the parameters could be converted to fields of the class. But this would often result in bad [[glossary:​cohesion]]. Because of that in such a case extracting a new class is the next step in adhering to the principle. ​ 
  
 ===== Rationale ===== ===== Rationale =====
Line 82: Line 82:
 public List<​ResultDto>​ buildResult(Set<​ResultEntity>​ resultSet) { public List<​ResultDto>​ buildResult(Set<​ResultEntity>​ resultSet) {
     List<​ResultDto>​ result = new ArrayList<>​();​     List<​ResultDto>​ result = new ArrayList<>​();​
-    ​forng code is better:+    ​for (ResultEntity entity : resultSet) { 
 +        ResultDto dto = new ResultDto();​ 
 +        dto.setShoeSize(entity.getShoeSize()); ​        
 +        dto.setNumberOfEarthWorms(entity.getNumberOfEarthWorms());​ 
 +        dto.setAge(computeAge(entity.getBirthday()));​ 
 +        result.add(dto);​ 
 +    } 
 +    return result; 
 +
 +</​code>​ 
 + 
 +There are two levels of abstractions in this method. First there is the loop which acts upon the whole result set and second there is the loop body which converts a single entity to a [[patterns:​Data Transfer Object|DTO]]. For the latter there is no syntactical grouping. The reader of the code has to find out that the first four lines of the loop body belong together. The code also doesn'​t explicitly state that these four lines convert an entity to a DTO. So the following ​code is better:
  
 <code java> <code java>
principles/single_level_of_abstraction.1524181143.txt.gz · Last modified: 2018-04-20 01:39 by 40.130.190.160